Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the PD client to adopt tikv/pd#8943 #1536

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Update the PD client to adopt tikv/pd#8943 #1536

merged 1 commit into from
Dec 23, 2024

Conversation

JmPotato
Copy link
Member

Adopt tikv/pd#8943.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 23, 2024
@JmPotato JmPotato changed the title Update the PD client Update the PD client to adopt pd#8943 Dec 23, 2024
@JmPotato JmPotato changed the title Update the PD client to adopt pd#8943 Update the PD client to adopt tikv/pd#8943 Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
@JmPotato
Update the PD client
b2e0642 
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rleungx, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-23 06:51:31.082417668 +0000 UTC m=+1458081.171220211: ☑️ agreed by rleungx.
  • 2024-12-23 06:55:19.593516045 +0000 UTC m=+1458309.682318589: ☑️ agreed by you06.
  • 2024-12-23 06:55:57.094286327 +0000 UTC m=+1458347.183088881: ✖️🔁 reset by JmPotato.
  • 2024-12-23 07:01:14.419226457 +0000 UTC m=+1458664.508028985: ☑️ agreed by you06.
  • 2024-12-23 07:06:35.080427414 +0000 UTC m=+1458985.169229957: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit fd950fc into tikv:master Dec 23, 2024
12 checks passed
@JmPotato JmPotato deleted the update_pd_client branch December 23, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@you06 you06 you06 approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @you06 @rleungx