Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tikv jemalloc fork #75

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Use tikv jemalloc fork #75

merged 1 commit into from
Mar 1, 2024

Conversation

jackkleeman
Copy link

As otherwise the commit doesn't reliably download on new checkout. This commit is only tagged in the tikv fork, and Github seems keen on GCing it from the original repo.

As otherwise the commit doesn't reliably download on new checkout

Signed-off-by: Jack Kleeman <[email protected]>
@BusyJay
Copy link
Member

BusyJay commented Feb 28, 2024

As otherwise the commit doesn't reliably download on new checkout.

What exact problems did you meet? Seems all tests run well.

@jackkleeman
Copy link
Author

[builder 1/3] RUN just arch=amd64 libc=gnu chef-cook --release --bin restate-server
#15 0.167 cargo chef cook --recipe-path recipe.json   --release --bin restate-server
#15 0.965     Updating git repository `[https://github.com/restatedev/aws-sdk-rust`](https://github.com/restatedev/aws-sdk-rust%60)
#15 2.341     Updating crates.io index
#15 2.398     Updating git repository `[https://github.com/restatedev/jemallocator`](https://github.com/restatedev/jemallocator%60)
#15 3.178     Updating git submodule `[https://github.com/jemalloc/jemalloc`](https://github.com/jemalloc/jemalloc%60)
#15 5.581 error: failed to get `tikv-jemallocator` as a dependency of package `restate-server v0.0.1 (/restate/server)`
#15 5.581 
#15 5.581 Caused by:
#15 5.581   failed to load source for dependency `tikv-jemallocator`
#15 5.581 
#15 5.581 Caused by:
#15 5.581   Unable to update https://github.com/restatedev/jemallocator?rev=f7adfca5aff272b43fd3ad896252b57fbbd9c72a#f7adfca5
#15 5.581 
#15 5.581 Caused by:
#15 5.581   failed to update submodule `jemalloc-sys/jemalloc`
#15 5.581 
#15 5.581 Caused by:
#15 5.581   object not found - no match for id (e13ca993e8ccb9ba9847cc330696e02839f328f7); class=Odb (9); code=NotFound (-3)
#15 5.585 thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-chef-0.1.62/src/recipe.rs:204:27:
#15 5.585 Exited with status code: 101
#15 5.585 stack backtrace:
#15 5.590    0: rust_begin_unwind
#15 5.590              at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:645:5
#15 5.590    1: core::panicking::panic_fmt
#15 5.590              at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:72:14
#15 5.590    2: chef::recipe::Recipe::cook
#15 5.591    3: cargo_chef::main
#15 5.591 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
#15 5.592 error: Recipe `chef-cook` failed on line 90 with exit code 101
#15 ERROR: process "/bin/sh -c just arch=$TARGETARCH libc=gnu chef-cook --release --bin restate-server" did not complete successfully: exit code: 101

@jackkleeman
Copy link
Author

Its sporadic, doesn't happen every time but certainly appears to be about git GC - the commit isn't in a branch or tag on that repo so its not guaranteed present I think?

@BusyJay
Copy link
Member

BusyJay commented Mar 1, 2024

I see, thanks!

@BusyJay BusyJay merged commit 8029693 into tikv:main Mar 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants