Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use String as span name #168

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Oct 26, 2023

  • Span name and event name now accept both &'static str and String (Into<Cow<'static, str>>), which previously only accept &'static str.
  • with_property and with_properties now accept impl Into<Cow<'static, str>>, which previously accept Cow<'static, str>.

@andylokandy andylokandy requested a review from zhongzc October 26, 2023 10:00
@coveralls
Copy link

coveralls commented Oct 26, 2023

Pull Request Test Coverage Report for Build 6652769436

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.6%) to 81.716%

Files with Coverage Reduction New Missed Lines %
minitrace-opentelemetry/src/lib.rs 1 82.09%
minitrace/src/collector/global_collector.rs 2 95.56%
minitrace/src/local/local_span.rs 2 93.44%
minitrace/src/local/span_queue.rs 2 92.68%
minitrace/src/util/mod.rs 2 91.18%
minitrace/src/util/tree.rs 4 97.04%
minitrace/src/local/local_span_stack.rs 6 93.02%
minitrace/src/local/raw_span.rs 8 71.43%
minitrace/src/span.rs 9 94.48%
Totals Coverage Status
Change from base Build 6238061320: -0.6%
Covered Lines: 1667
Relevant Lines: 2040

💛 - Coveralls

Signed-off-by: Andy Lok <[email protected]>
@andylokandy andylokandy merged commit 5d00e2b into tikv:master Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants