Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): update opentelemetry to latest version #181

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

dotansimha
Copy link
Contributor

Seems like the latest version of opentelemetry crates now needs to use opentelemetry_sdk instead of opentelemetry::sdk, and also some types needs to be modified to support the latest API changes.

@dotansimha dotansimha force-pushed the latest-otel branch 3 times, most recently from f6d900a to 2f3bad8 Compare January 22, 2024 17:30
@dotansimha
Copy link
Contributor Author

@andylokandy I've updated all the examples and docs. Should pass lint checks now.

@dotansimha
Copy link
Contributor Author

@andylokandy I rebased and everything passes locally. can you please approve the CI pipelines so we can see if it's passing in CI?

@dotansimha
Copy link
Contributor Author

@andylokandy it passes now 🎉

Copy link
Collaborator

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@andylokandy andylokandy merged commit 8161a78 into tikv:master Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants