-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: single thread mode #201
Conversation
Signed-off-by: Andy Lok <[email protected]>
Signed-off-by: Andy Lok <[email protected]>
Pull Request Test Coverage Report for Build 7774880861
💛 - Coveralls |
Using this PR along with wasm32 runtime, I get |
maybe this one? https://github.com/tikv/minitrace-rust/blob/master/minitrace/src/collector/global_collector.rs#L211 EDIT: Yeah that's the one :) I can confirm changing it does not fail, checking the |
@andylokandy ok with this commit dotansimha@ca4ab0d , it seems to work and it does not fail on the I'm trying to use
The macro seems to set EDIT: Also using 🤔 |
did you set_local_parent()? and drop all spans before flush? |
oops, I missed that 🤦 I added it now and it seems to work! 🎉 So I think the only fix needed for PR is dotansimha@ca4ab0d |
@andylokandy can we get this released to Crates? 👀 Thank you |
Signed-off-by: Andy Lok [email protected]
Closes #197