Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tokio rt-multi-thread for example #214

Merged
merged 1 commit into from
May 2, 2024

Conversation

morristai
Copy link
Contributor

In /minitrace/examples, we will need rt-multi-thread for Tokio in order to run both the synchronous and asynchronous examples. Here's a screenshot providing evidence:

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8905120345

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 78.835%

Totals Coverage Status
Change from base Build 8612241961: 0.2%
Covered Lines: 1732
Relevant Lines: 2197

💛 - Coveralls

@zhongzc
Copy link
Collaborator

zhongzc commented May 1, 2024

Hi @morristai, thanks for your contribution!

I'm ready to merge your PR as soon as the DCO check is passed. Here's the link to the DCO status.

@morristai morristai force-pushed the chore/fix_example_dependency branch from e414238 to fa1271c Compare May 1, 2024 15:27
@morristai
Copy link
Contributor Author

Hi @morristai, thanks for your contribution!

I'm ready to merge your PR as soon as the DCO check is passed. Here's the link to the DCO status.

Addressed!

@zhongzc zhongzc merged commit a75c86d into tikv:master May 2, 2024
8 of 9 checks passed
@morristai morristai deleted the chore/fix_example_dependency branch May 2, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants