fix: add tokio rt-multi-thread for example #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8905120345Details
💛 - Coveralls |
|
Hi @morristai, thanks for your contribution! I'm ready to merge your PR as soon as the DCO check is passed. Here's the link to the DCO status. |
Signed-off-by: Morris Tai <[email protected]>
morristai
force-pushed
the
chore/fix_example_dependency
branch
from
e414238 to
fa1271c
Compare
Addressed! |
zhongzc
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
/minitrace/examples, we will needrt-multi-threadfor Tokio in order to run both the synchronous and asynchronous examples. Here's a screenshot providing evidence: