fix comment

Signed-off-by: okJiang <[email protected]>
tikv · Jun 12, 2024 · adb5543 · adb5543
1 parent 52c1e83
commit adb5543
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/client/pd_service_discovery.go b/client/pd_service_discovery.go
@@ -806,7 +806,7 @@ func (c *pdServiceDiscovery) SetTSOGlobalServURLUpdatedCallback(callback tsoGlob
 	url := c.getLeaderURL()
 	if len(url) > 0 {
 		if err := callback(url); err != nil {
-			log.Error("[tso] failed to call callback", errs.ZapError(err))
+			log.Error("[tso] failed to call back when tso global service url update", zap.String("url", url), errs.ZapError(err))
 		}
 	}
 	c.tsoGlobalAllocLeaderUpdatedCb = callback

diff --git a/client/resource_manager_client.go b/client/resource_manager_client.go
@@ -320,7 +320,7 @@ func (c *client) handleResourceTokenDispatcher(dispatcherCtx context.Context, tb
 		if toReconnect {
 			connection.reset()
 			if err := c.tryResourceManagerConnect(dispatcherCtx, &connection); err != nil {
-				log.Error("[resource_manager] try connect leader failed", errs.ZapError(err))
+				log.Error("[resource_manager] try to connect token leader failed", errs.ZapError(err))
 			}
 			log.Info("[resource_manager] token leader may change, try to reconnect the stream")
 			stream, streamCtx = connection.stream, connection.ctx

diff --git a/client/tso_service_discovery.go b/client/tso_service_discovery.go
@@ -369,7 +369,7 @@ func (c *tsoServiceDiscovery) SetTSOGlobalServURLUpdatedCallback(callback tsoGlo
 	url := c.getPrimaryURL()
 	if len(url) > 0 {
 		if err := callback(url); err != nil {
-			log.Error("[tso] failed to call callback", errs.ZapError(err))
+			log.Error("[tso] failed to call back when tso global service url update", zap.String("url", url), errs.ZapError(err))
 		}
 	}
 	c.globalAllocPrimariesUpdatedCb = callback

diff --git a/pkg/mcs/utils/util.go b/pkg/mcs/utils/util.go
@@ -267,7 +267,7 @@ func StopHTTPServer(s server) {
 	go func() {
 		defer close(ch)
 		if err := s.GetHTTPServer().Shutdown(ctx); err != nil {
-			log.Warn("http server graceful shutdown failed", errs.ZapError(err))
+			log.Error("http server graceful shutdown failed", errs.ZapError(err))
 		}
 	}()
 

diff --git a/pkg/replication/replication_mode.go b/pkg/replication/replication_mode.go
@@ -251,10 +251,10 @@ func (m *ModeManager) drSwitchToAsyncWait(availableStores []uint64) error {
 	return nil
 }
 
-func (m *ModeManager) drSwitchToAsync(availableStores []uint64) {
+func (m *ModeManager) drSwitchToAsync(availableStores []uint64) error {
 	m.Lock()
 	defer m.Unlock()
-	_ = m.drSwitchToAsyncWithLock(availableStores)
+	return m.drSwitchToAsyncWithLock(availableStores)
 }
 
 func (m *ModeManager) drSwitchToAsyncWithLock(availableStores []uint64) error {