client: remove the deprecate function grpc.WithInsecure()
#5447
Conversation
Signed-off-by: bufferflies <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note-none
| @@ -42,11 +43,11 @@ const ForwardMetadataKey = "pd-forwarded-host" | |||
| // ctx will be noop. Users should call ClientConn.Close to terminate all the | |||
| // pending operations after this function returns. | |||
| func GetClientConn(ctx context.Context, addr string, tlsCfg *tls.Config, do ...grpc.DialOption) (*grpc.ClientConn, error) { | |||
| opt := grpc.WithInsecure() //nolint | |||
| creds := insecure.NewCredentials() | |||
There was a problem hiding this comment.
Should we replace all WithInsecure with insecure.NewCredentials()?
There was a problem hiding this comment.
no, some grpc version is not same, the etcd can not upgrade to 1.43.
ti-chi-bot
added
status/LGT2
|
ci failed @bufferflies |
|
reopen if the etcd grpc version can upgrade to 1.43. |
Signed-off-by: bufferflies [email protected]
What problem does this PR solve?
Issue Number: Close #4399.
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note