Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: refactor and make pd-ctl helper support mcs #7120

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 20, 2023

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

  1. move mustPutStore, and movePutRegion out from pdtcl, because they are used by other modules.
  2. make mustPutStore, and movePutRegion support to forward scheduling server.
  3. replace cluster.GetServer(cluster.GetLeader()) with cluster.GetLeaderServer()

Check List

Tests

  • Unit test

Release note

None.

@lhy1024 lhy1024 added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and HunDunDM September 20, 2023 07:32
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #7120 (1873ce1) into master (5b3d017) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 60.00%.

❗ Current head 1873ce1 differs from pull request most recent head 4e4ecf2. Consider uploading reports for the commit 4e4ecf2 to get more accurate results

@@            Coverage Diff             @@
##           master    #7120      +/-   ##
==========================================
- Coverage   74.37%   74.35%   -0.03%     
==========================================
  Files         440      440              
  Lines       47209    47155      -54     
==========================================
- Hits        35114    35062      -52     
+ Misses       9007     9000       -7     
- Partials     3088     3093       +5     
Flag Coverage Δ
unittests 74.35% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 21, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b0593e2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 96ace89 into tikv:master Sep 21, 2023
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants