Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: fix unstable test TestSkipConsumptionForBackgroundJobs #7130

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Sep 21, 2023

What problem does this PR solve?

Issue Number: Close #7129

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Signed-off-by: husharp <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 21, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx September 21, 2023 10:43
@HuSharp HuSharp removed the request for review from HunDunDM September 21, 2023 10:43
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2023
@HuSharp HuSharp requested review from lhy1024 and removed request for rleungx September 21, 2023 10:43
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2023
@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 21, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Sep 22, 2023

@lhy1024 can you rerun pr and leave a merge label? :) thx!
ci failed because of dashboard failed, I will investigate it.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #7130 (19adc56) into master (e6c8841) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 19adc56 differs from pull request most recent head c6eb06c. Consider uploading reports for the commit c6eb06c to get more accurate results

@@           Coverage Diff           @@
##           master    #7130   +/-   ##
=======================================
  Coverage   74.31%   74.32%           
=======================================
  Files         440      440           
  Lines       47217    47217           
=======================================
+ Hits        35088    35092    +4     
+ Misses       9034     9030    -4     
  Partials     3095     3095           
Flag Coverage Δ
unittests 74.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor

nolouch commented Sep 25, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 19adc56

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2023
@CabinfeverB
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
@CabinfeverB
Copy link
Member

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 3c632b1 into tikv:master Sep 25, 2023
19 checks passed
@HuSharp HuSharp deleted the fix_test_background branch October 16, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestSkipConsumptionForBackgroundJobs is unstable
4 participants