Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tidb-dashboard to v2023.09.21.1 #7136

Merged
merged 1 commit into from
Sep 25, 2023
Merged

chore: update tidb-dashboard to v2023.09.21.1 #7136

merged 1 commit into from
Sep 25, 2023

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Sep 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7137

What is changed and how does it work?

Related tidb-dashboard release: pingcap/tidb-dashboard#1596

- security fixes
- hide full stacktrace info in error message

Release note

None.

Test

$ tiup playground v6.5.5 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 22, 2023
@ti-chi-bot ti-chi-bot bot requested review from rleungx and Yisaer September 22, 2023 05:59
@baurine baurine marked this pull request as draft September 22, 2023 05:59
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2023
@baurine baurine force-pushed the chore/update-tidb-dashobard branch from f419459 to a3bf36f Compare September 22, 2023 06:03
@baurine baurine marked this pull request as ready for review September 22, 2023 06:13
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2023
@HuSharp HuSharp requested review from nolouch, CabinfeverB and HuSharp and removed request for Yisaer September 22, 2023 06:15
@HuSharp
Copy link
Member

HuSharp commented Sep 22, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 22, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 22, 2023
HuSharp
HuSharp reviewed Sep 22, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2023
@baurine
Copy link
Contributor Author

baurine commented Sep 25, 2023

/ok-to-test

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@rleungx
Copy link
Member

rleungx commented Sep 25, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a3bf36f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 9b04f25 into tikv:release-6.5 Sep 25, 2023
13 checks passed
@baurine baurine deleted the chore/update-tidb-dashobard branch September 25, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@CabinfeverB CabinfeverB Awaiting requested review from CabinfeverB

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baurine @HuSharp @rleungx @ti-chi-bot