-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tso: improve skipping sync condition and add more logs #7139
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
6a32123
to
65f2a17
Compare
Codecov Report
@@ Coverage Diff @@
## master #7139 +/- ##
==========================================
+ Coverage 74.31% 74.33% +0.02%
==========================================
Files 440 440
Lines 47217 47194 -23
==========================================
- Hits 35088 35083 -5
+ Misses 9034 9010 -24
- Partials 3095 3101 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: JmPotato <[email protected]>
65f2a17
to
c441471
Compare
Signed-off-by: JmPotato <[email protected]>
c441471
to
9409d62
Compare
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
/merge |
1 similar comment
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 545363b
|
This pull request has been accepted and is ready to merge. Commit hash: 545363b
|
/hold |
/hold |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #7138.
What is changed and how does it work?
Check List
Tests
Release note