Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr-autosync: add metrics (#7110) #7153

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7110

What problem does this PR solve?

Issue Number: Close #6975

What is changed and how does it work?

add some dr-autosync related metrics

image

numbers are used to distinguish different states, the map is

1: sync
2: async_wait
3: async
4: sync_recover

Check List

Tests

  • Manual test (add detailed scripts or steps below)

sync state

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 1
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 10
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 64

async wait

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 2
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 221
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 311

async

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 3
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 222
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 385

sync recover

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0.24528302252292633
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 4
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 223
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 393

sync

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 1
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 53
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 1
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 224
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 614

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 26, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-7110-to-release-6.5 branch from d771446 to 7e717e2 Compare September 26, 2023 02:30
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
server/cluster/cluster.go 81.71% <100.00%> (+0.32%) ⬆️
server/core/region.go 90.24% <100.00%> (+0.05%) ⬆️
server/replication/metrics.go 100.00% <100.00%> (ø)
server/statistics/region.go 100.00% <100.00%> (ø)
server/statistics/region_collection.go 97.48% <100.00%> (ø)
server/replication/replication_mode.go 82.81% <84.61%> (+0.07%) ⬆️

... and 20 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 26, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 26, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3086f25

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit ed629e9 into tikv:release-6.5 Sep 26, 2023
@HuSharp HuSharp deleted the cherry-pick-7110-to-release-6.5 branch September 26, 2023 08:28
disksing added a commit to oh-my-tidb/pd that referenced this pull request Oct 30, 2023
disksing added a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants