Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: delete slow stats after store tombstone #7181

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 9, 2023

What problem does this PR solve?

Issue Number: Close #7180.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 9, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 October 9, 2023 06:10
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2023
@rleungx rleungx requested review from JmPotato and removed request for disksing October 9, 2023 06:12
@rleungx
Copy link
Member Author

rleungx commented Oct 9, 2023

/cc @LykxSassinator

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2023

@rleungx: GitHub didn't allow me to request PR reviews from the following users: LykxSassinator.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @LykxSassinator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #7181 (cf85819) into master (2266c94) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head cf85819 differs from pull request most recent head f6b9caa. Consider uploading reports for the commit f6b9caa to get more accurate results

@@            Coverage Diff             @@
##           master    #7181      +/-   ##
==========================================
+ Coverage   74.56%   74.63%   +0.07%     
==========================================
  Files         442      441       -1     
  Lines       47436    47392      -44     
==========================================
+ Hits        35371    35372       +1     
+ Misses       8970     8932      -38     
+ Partials     3095     3088       -7     
Flag Coverage Δ
unittests 74.63% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2023
@rleungx
Copy link
Member Author

rleungx commented Oct 10, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cf85819

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c7b68a2 into tikv:master Oct 10, 2023
19 checks passed
@rleungx rleungx deleted the delete-slow-stats branch October 10, 2023 09:49
lhy1024 pushed a commit to lhy1024/pd that referenced this pull request Oct 12, 2023
close tikv#7180

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7180

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow stats is not deleted
3 participants