mcs: support history hot region in scheduling server #7183
Conversation
Signed-off-by: lhy1024 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
Codecov Report
@@ Coverage Diff @@
## master #7183 +/- ##
=======================================
Coverage 74.56% 74.57%
=======================================
Files 441 442 +1
Lines 47388 47448 +60
=======================================
+ Hits 35335 35382 +47
- Misses 8957 8958 +1
- Partials 3096 3108 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: lhy1024 <[email protected]>
lhy1024
force-pushed
the
move-history-hot
branch
from
e57d250 to
845e271
Compare
| } | ||
|
|
||
| h := handler.NewHandler(&svr{s}) | ||
| s.hotRegionStorage, err = storage.NewHotRegionsStorage( |
There was a problem hiding this comment.
Will it make the scheduling server stateful？
There was a problem hiding this comment.
It will create a leveldb in scheduling server.
If hope to store it in api server, it means that we need to pull all hot region info from scheduling server per 10 minutes
https://docs.pingcap.com/zh/tidb/stable/information-schema-tidb-hot-regions-history
There was a problem hiding this comment.
Scheduling server should be stateless.
|
After discussion, this pr will be suspended. |
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: Ref #5839
What is changed and how does it work?
Check List
Tests
Release note