Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: forward ask split request #7208

Merged
merged 2 commits into from
Oct 19, 2023
Merged

mcs: forward ask split request #7208

merged 2 commits into from
Oct 19, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Oct 16, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch October 16, 2023 04:21
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 16, 2023
@rleungx rleungx requested review from JmPotato and lhy1024 and removed request for nolouch and disksing October 16, 2023 04:22
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #7208 (9f8f302) into master (8b2896b) will decrease coverage by 0.27%.
Report is 3 commits behind head on master.
The diff coverage is 25.27%.

@@            Coverage Diff             @@
##           master    #7208      +/-   ##
==========================================
- Coverage   74.65%   74.38%   -0.27%     
==========================================
  Files         442      442              
  Lines       47744    47956     +212     
==========================================
+ Hits        35642    35671      +29     
- Misses       8957     9134     +177     
- Partials     3145     3151       +6
Flag Coverage Δ
unittests 74.38% <25.27%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx mentioned this pull request Oct 17, 2023
Merged
@rleungx rleungx force-pushed the ask-split branch 2 times, most recently from 4691795 to 0c13e63 Compare October 17, 2023 08:06
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2023
@rleungx
forward ask split request
b6d04c6 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
update kvproto
9f8f302 
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 19, 2023
lhy1024
lhy1024 approved these changes Oct 19, 2023
View reviewed changes
client/go.mod Outdated
@@ -41,3 +41,5 @@ require (
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/pingcap/kvproto => github.com/rleungx/kvproto v0.0.0-20231017074040-7aea7783b691
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need update kvproto

pkg/mcs/scheduling/server/grpc_service.go
@@ -254,6 +257,74 @@ func (s *Service) GetOperator(ctx context.Context, request *schedulingpb.GetOper
}, nil
}

// AskBatchSplit implements gRPC PDServer.
func (s *Service) AskBatchSplit(ctx context.Context, request *schedulingpb.AskBatchSplitRequest) (*schedulingpb.AskBatchSplitResponse, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be similar to HandleAskBatchSplit, could we reduce it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2023
@rleungx
Copy link
Member Author

rleungx commented Oct 19, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9f8f302

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2023
@ti-chi-bot ti-chi-bot bot merged commit 43ff408 into tikv:master Oct 19, 2023
21 of 23 checks passed
@rleungx rleungx deleted the ask-split branch October 19, 2023 09:44
@rleungx rleungx mentioned this pull request Oct 23, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
mcs: forward ask split request (tikv#7208)
1648b24 
ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @JmPotato @lhy1024