Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: update version to fix some security issues #7212

Merged
merged 5 commits into from
Oct 17, 2023
Merged

dashboard: update version to fix some security issues #7212

merged 5 commits into from
Oct 17, 2023

Conversation

mornyx
Copy link
Contributor

@mornyx mornyx commented Oct 16, 2023

What problem does this PR solve?

Issue Number: Close #7211

What is changed and how does it work?

Check List

Tests

  • No code

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

Hi @mornyx. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx October 16, 2023 09:14
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
mornyx added 2 commits October 16, 2023 17:18
@mornyx
go mod tidy
51ef7d9 
Signed-off-by: mornyx <[email protected]>
@mornyx
downgrade
ce92378 
Signed-off-by: mornyx <[email protected]>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 16, 2023
@nolouch
Copy link
Contributor

nolouch commented Oct 16, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 16, 2023
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 16, 2023
@nolouch
Copy link
Contributor

nolouch commented Oct 16, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ce92378

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2023
@mornyx
Copy link
Contributor Author

mornyx commented Oct 16, 2023

/run-all-tests

@mornyx
Copy link
Contributor Author

mornyx commented Oct 16, 2023

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2023
@rleungx
Copy link
Member

rleungx commented Oct 17, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a958f91

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
server/config/config.go 75.76% <ø> (ø)

... and 37 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot merged commit 462a056 into tikv:release-7.1 Oct 17, 2023
17 checks passed
@mornyx mornyx deleted the release-7.1 branch October 24, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@baurine baurine baurine approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mornyx @nolouch @rleungx @baurine @ti-chi-bot @HuSharp