Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: transplant the recovery-duration setting to evict-slow-store scheduler. #7225

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

LykxSassinator
Copy link
Contributor

Reference PR: #7132

What problem does this PR solve?

Issue Number: Ref #7156

What is changed and how does it work?

This pr is used to transplant the `recovery-duration` imported in `evict-slow-trend`
scheduler into `evict-slow-store` scheduler. 

It's useful and necessary for users who wanna use `evict-slow-score` scheduler
before we GA `evict-slow-trend` scheduler.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

…-store` scheduler.

This pr is used to transplant the `recovery-duration` imported in `evict-slow-trend` scheduler
into `evict-slow-store` scheduler. It's useful and necessary for users who wanna use
`evict-slow-score` scheduler before we GA `evict-slow-trend` scheduler.

Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from rleungx and Yisaer October 18, 2023 08:00
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2023
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Copy link
Contributor Author

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

@LykxSassinator: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #7225 (96983a3) into master (8b2896b) will decrease coverage by 0.27%.
Report is 5 commits behind head on master.
The diff coverage is 35.45%.

❗ Current head 96983a3 differs from pull request most recent head 91c78e5. Consider uploading reports for the commit 91c78e5 to get more accurate results

@@            Coverage Diff             @@
##           master    #7225      +/-   ##
==========================================
- Coverage   74.65%   74.38%   -0.27%     
==========================================
  Files         442      442              
  Lines       47744    48003     +259     
==========================================
+ Hits        35642    35708      +66     
- Misses       8957     9133     +176     
- Partials     3145     3162      +17     
Flag Coverage Δ
unittests 74.38% <35.45%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2023
@nolouch
Copy link
Contributor

nolouch commented Oct 19, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 19, 2023
@nolouch
Copy link
Contributor

nolouch commented Oct 19, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 96983a3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

@LykxSassinator: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit d9dbf77 into tikv:master Oct 19, 2023
19 checks passed
@LykxSassinator LykxSassinator deleted the ctrl_slowness_recovery branch October 19, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants