-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedulers: transplant the recovery-duration
setting to evict-slow-store
scheduler.
#7225
schedulers: transplant the recovery-duration
setting to evict-slow-store
scheduler.
#7225
Conversation
…-store` scheduler. This pr is used to transplant the `recovery-duration` imported in `evict-slow-trend` scheduler into `evict-slow-store` scheduler. It's useful and necessary for users who wanna use `evict-slow-score` scheduler before we GA `evict-slow-trend` scheduler. Signed-off-by: lucasliang <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @LykxSassinator. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: lucasliang <[email protected]>
/test |
@LykxSassinator: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #7225 +/- ##
==========================================
- Coverage 74.65% 74.38% -0.27%
==========================================
Files 442 442
Lines 47744 48003 +259
==========================================
+ Hits 35642 35708 +66
- Misses 8957 9133 +176
- Partials 3145 3162 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
/ok-to-test |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 96983a3
|
@LykxSassinator: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Reference PR: #7132
What problem does this PR solve?
Issue Number: Ref #7156
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note