Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add integration test and ci workflow for real tiup #7317

Closed
wants to merge 3 commits into from
Closed

tests: add integration test and ci workflow for real tiup #7317

wants to merge 3 commits into from

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Nov 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #7298. wait #7304 merged

What is changed and how does it work?

support tests with real tiup

Check List

Tests

  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 3, 2023
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx November 3, 2023 08:23
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 3, 2023
@HuSharp HuSharp removed request for nolouch and rleungx November 3, 2023 08:27
@HuSharp HuSharp force-pushed the add_integration_test branch from 67676c2 to c544fc5 Compare November 3, 2023 08:45
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 3, 2023
@HuSharp HuSharp force-pushed the add_integration_test branch from c544fc5 to 91dda86 Compare November 6, 2023 03:21
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2023
@HuSharp HuSharp force-pushed the add_integration_test branch 8 times, most recently from 568fe93 to 9904a82 Compare November 6, 2023 03:49
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2023
@HuSharp HuSharp force-pushed the add_integration_test branch 4 times, most recently from 0b93739 to 881c9f3 Compare November 6, 2023 04:40
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2023
@HuSharp HuSharp force-pushed the add_integration_test branch 2 times, most recently from 11be32d to ef78e35 Compare November 8, 2023 07:18
@HuSharp HuSharp marked this pull request as ready for review November 8, 2023 07:19
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
@HuSharp HuSharp changed the title [DNM] add integration test for real tidb tests: add integration test and ci workflow for real tiup Nov 8, 2023
@HuSharp HuSharp force-pushed the add_integration_test branch 4 times, most recently from afc0c62 to 7602ade Compare November 13, 2023 07:13
@HuSharp
add test
a43139d 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the add_integration_test branch from 7602ade to a43139d Compare November 13, 2023 07:26
JmPotato
JmPotato approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM. We could gradually improve the test cases later.

client/client.go Outdated Show resolved Hide resolved
Makefile
LDFLAGS += -X "$(PD_PKG)/pkg/versioninfo.PDReleaseVersion=$(shell git describe --tags --dirty --always)"
RELEASE_VERSION ?= $(shell git describe --tags --dirty --always)
ifeq ($(RUN_CI), 1)
RELEASE_VERSION := None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set it to None?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no tag in the ci environment, we can not pass

pd/server/util.go

Lines 39 to 41 in bfc988b

if versioninfo.PDReleaseVersion != "None" {
pdVersion = versioninfo.MustParseVersion(versioninfo.PDReleaseVersion)
}
whithout tag :(

client/http/api.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 14, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch
Copy link
Contributor

nolouch commented Nov 27, 2023

need fix conflicts.

@JmPotato
Copy link
Member

/hold

We are trying to use unified Jenkins CI integration instead of using GitHub Actions.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Dec 5, 2023

replaced by #7493

@HuSharp HuSharp closed this Dec 5, 2023
@HuSharp HuSharp deleted the add_integration_test branch December 5, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

@CabinfeverB CabinfeverB Awaiting requested review from CabinfeverB

@rleungx rleungx Awaiting requested review from rleungx

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @nolouch @JmPotato