-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support mcs api for members #7372
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7372 +/- ##
==========================================
+ Coverage 74.58% 74.62% +0.03%
==========================================
Files 454 455 +1
Lines 50142 50197 +55
==========================================
+ Hits 37399 37460 +61
+ Misses 9415 9393 -22
- Partials 3328 3344 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
041c6ba
to
d57a96a
Compare
d57a96a
to
3f5ae0a
Compare
3f5ae0a
to
a074765
Compare
a074765
to
95345fb
Compare
05c118f
to
920fbe2
Compare
920fbe2
to
8abc1c1
Compare
215cb70
to
3fb1c20
Compare
3fb1c20
to
2ef354f
Compare
Signed-off-by: husharp <[email protected]>
53620e6
to
22f01fd
Compare
Signed-off-by: husharp <[email protected]>
02c694a
to
d44ab8b
Compare
Signed-off-by: husharp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
Signed-off-by: husharp <[email protected]>
/test ? |
@HuSharp: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-integration-realcluster-test |
1 similar comment
/test pull-integration-realcluster-test |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ea054a3
|
What problem does this PR solve?
Issue Number: Ref #7519
What is changed and how does it work?
Check List
Tests
Release note