Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support mcs api for members #7372

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Nov 15, 2023

What problem does this PR solve?

Issue Number: Ref #7519

What is changed and how does it work?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 15, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx November 15, 2023 10:10
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #7372 (ea054a3) into master (a4ab7d3) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7372      +/-   ##
==========================================
+ Coverage   74.58%   74.62%   +0.03%     
==========================================
  Files         454      455       +1     
  Lines       50142    50197      +55     
==========================================
+ Hits        37399    37460      +61     
+ Misses       9415     9393      -22     
- Partials     3328     3344      +16     
Flag Coverage Δ
unittests 74.62% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp force-pushed the support_tso_api branch 3 times, most recently from 041c6ba to d57a96a Compare November 16, 2023 06:33
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2023
@HuSharp HuSharp force-pushed the support_tso_api branch 2 times, most recently from 215cb70 to 3fb1c20 Compare December 11, 2023 02:43
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested a review from JmPotato December 18, 2023 03:47
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2023
@HuSharp HuSharp changed the title api: support mcs api for members and leader api: support mcs api for members Dec 18, 2023
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

pkg/mcs/discovery/discover.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Dec 18, 2023

/test ?

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

@HuSharp: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Member Author

HuSharp commented Dec 18, 2023

/test pull-integration-realcluster-test

1 similar comment
@HuSharp
Copy link
Member Author

HuSharp commented Dec 18, 2023

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 18, 2023
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ea054a3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit a16f99e into tikv:master Dec 18, 2023
25 of 27 checks passed
@HuSharp HuSharp deleted the support_tso_api branch December 18, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants