*: make max backoff shorter #7823

rleungx · 2024-02-18T09:23:18Z

What problem does this PR solve?

Issue Number: Close #7821.

What is changed and how does it work?

This PR changes the gRPC connection backoff config to reduce the recovery time.

Check List

Tests

Integration test

Release note

None.

ti-chi-bot · 2024-02-18T09:23:20Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

lhy1024 · 2024-02-19T02:47:55Z

client/grpcutil/grpcutil.go

@@ -62,7 +63,15 @@ func GetClientConn(ctx context.Context, addr string, tlsCfg *tls.Config, do ...g
 	if err != nil {
 		return nil, errs.ErrURLParse.Wrap(err).GenWithStackByCause()
 	}
-	cc, err := grpc.DialContext(ctx, u.Host, append(do, opt)...)
+	backoffOpts := grpc.WithConnectParams(grpc.ConnectParams{


why use this config? Do we need to add some comments here?

codecov · 2024-02-27T09:19:30Z

Codecov Report

Merging #7823 (a148a1b) into master (e199866) will decrease coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7823      +/-   ##
==========================================
- Coverage   73.52%   73.41%   -0.12%     
==========================================
  Files         432      432              
  Lines       47937    47953      +16     
==========================================
- Hits        35248    35204      -44     
- Misses       9650     9696      +46     
- Partials     3039     3053      +14

Flag	Coverage Δ
unittests	`73.41% <100.00%> (-0.12%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Ryan Leung <[email protected]>

CabinfeverB · 2024-02-28T07:28:23Z

pkg/utils/grpcutil/grpcutil.go

-	cc, err := grpc.DialContext(ctx, u.Host, append(do, opt)...)
+	backoffOpts := grpc.WithConnectParams(grpc.ConnectParams{
+		Backoff: backoff.Config{
+			BaseDelay:  100 * time.Millisecond,


I found the BaseDelay is 1s in

pd/pkg/syncer/client.go

Line 117 in e199866

grpc.WithConnectParams(grpc.ConnectParams{

.
Do we need keep them same?

Signed-off-by: Ryan Leung <[email protected]>

nolouch

lgtm. and need some comments as @lhy1024 says.

Signed-off-by: Ryan Leung <[email protected]>

rleungx · 2024-02-29T06:35:29Z

/merge

ti-chi-bot · 2024-02-29T06:35:31Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-02-29T06:35:32Z

This pull request has been accepted and is ready to merge.

Commit hash: 22638b5

niubell · 2024-03-01T01:37:19Z

client/grpcutil/grpcutil.go

+			BaseDelay:  time.Second,
+			Multiplier: 1.6,
+			Jitter:     0.2,
+			MaxDelay:   3 * time.Second,


How about making MaxDelay configurable through some WithXX function to meet different callers‘s requests?

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Feb 18, 2024

ti-chi-bot bot requested review from lhy1024 and nolouch February 18, 2024 09:23

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2024

lhy1024 reviewed Feb 19, 2024

View reviewed changes

rleungx force-pushed the make-backoff-shorter branch from bcedbda to 2d56f9a Compare February 27, 2024 09:09

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2024

change the backoff

99a232e

Signed-off-by: Ryan Leung <[email protected]>

rleungx force-pushed the make-backoff-shorter branch from 2d56f9a to 99a232e Compare February 28, 2024 07:14

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Feb 28, 2024

CabinfeverB reviewed Feb 28, 2024

View reviewed changes

change the backoff

c2996e7

Signed-off-by: Ryan Leung <[email protected]>

CabinfeverB approved these changes Feb 28, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2024

nolouch approved these changes Feb 29, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 29, 2024

add comment

22638b5

Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Feb 29, 2024

lhy1024 approved these changes Feb 29, 2024

View reviewed changes

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 29, 2024

Merge branch 'master' into make-backoff-shorter

a148a1b

ti-chi-bot bot merged commit 92a31c1 into tikv:master Feb 29, 2024
25 of 26 checks passed

rleungx mentioned this pull request Feb 29, 2024

Update pd client to the latest master tikv/client-go#1195

Merged

rleungx deleted the make-backoff-shorter branch February 29, 2024 07:18

rleungx mentioned this pull request Feb 29, 2024

*: update pd client pingcap/tidb#51418

Merged

13 tasks

niubell reviewed Mar 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: make max backoff shorter #7823

*: make max backoff shorter #7823

rleungx commented Feb 18, 2024 •

edited

Loading

ti-chi-bot bot commented Feb 18, 2024 •

edited

Loading

lhy1024 Feb 19, 2024

codecov bot commented Feb 27, 2024 •

edited

Loading

CabinfeverB Feb 28, 2024

rleungx Feb 28, 2024

nolouch left a comment

rleungx commented Feb 29, 2024

ti-chi-bot bot commented Feb 29, 2024

ti-chi-bot bot commented Feb 29, 2024

niubell Mar 1, 2024

*: make max backoff shorter #7823

*: make max backoff shorter #7823

Conversation

rleungx commented Feb 18, 2024 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Feb 18, 2024 • edited Loading

lhy1024 Feb 19, 2024

Choose a reason for hiding this comment

codecov bot commented Feb 27, 2024 • edited Loading

Codecov Report

CabinfeverB Feb 28, 2024

Choose a reason for hiding this comment

rleungx Feb 28, 2024

Choose a reason for hiding this comment

nolouch left a comment

Choose a reason for hiding this comment

rleungx commented Feb 29, 2024

ti-chi-bot bot commented Feb 29, 2024

ti-chi-bot bot commented Feb 29, 2024

niubell Mar 1, 2024

Choose a reason for hiding this comment

rleungx commented Feb 18, 2024 •

edited

Loading

ti-chi-bot bot commented Feb 18, 2024 •

edited

Loading

codecov bot commented Feb 27, 2024 •

edited

Loading