Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: only output the log when picked count > 0 (#7845) #7977

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7845

What problem does this PR solve?

Issue Number: close #7844.

What is changed and how does it work?

Only output the log when picked count > 0 in `updateEvictedEps`.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #7977 (f22dac6) into release-7.5 (3488a65) will increase coverage by 0.10%.
Report is 3 commits behind head on release-7.5.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7977      +/-   ##
===============================================
+ Coverage        74.53%   74.64%   +0.10%     
===============================================
  Files              444      444              
  Lines            48140    48156      +16     
===============================================
+ Hits             35882    35945      +63     
+ Misses            9073     9031      -42     
+ Partials          3185     3180       -5     
Flag Coverage Δ
unittests 74.64% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 25, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 25, 2024

This pull request has been accepted and is ready to merge.

Commit hash: f22dac6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8783927 into tikv:release-7.5 Mar 25, 2024
25 checks passed
@HuSharp HuSharp deleted the cherry-pick-7845-to-release-7.5 branch March 25, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants