ci: transitioning action version from node 16 to node 20 #8071

HuSharp · 2024-04-16T02:58:02Z

What problem does this PR solve?

Issue Number: Close #8070

What is changed and how does it work?

Check List

Tests

No code

Release note

None.

Signed-off-by: husharp <[email protected]>

ti-chi-bot · 2024-04-16T02:58:04Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2024-04-16T02:58:04Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: husharp <[email protected]>

codecov · 2024-04-16T03:27:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (22543a9) to head (c04dca0).
Report is 245 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8071      +/-   ##
==========================================
+ Coverage   77.28%   77.34%   +0.06%     
==========================================
  Files         469      469              
  Lines       61097    61097              
==========================================
+ Hits        47218    47255      +37     
+ Misses      10325    10284      -41     
- Partials     3554     3558       +4

Flag	Coverage Δ
unittests	`77.34% <ø> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <[email protected]>

HuSharp · 2024-04-16T05:31:58Z

.github/workflows/pd-tests.yaml

+          pattern: cover-reports-*
+          merge-multiple: true


added because
https://github.com/actions/upload-artifact/blob/ef09cdac3e2d3e60d8ccadda691f4f1cec5035cb/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

the pattern: input will filter the downloaded Artifacts to match the name specified.

the merge-multiple: input will support downloading multiple Artifacts to the same directory.

HuSharp · 2024-04-16T05:33:01Z

.github/workflows/pd-tests.yaml

-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-            **/.tools
-            **/.dashboard_download_cache
-          key: ${{ runner.os }}-go-${{ matrix.worker_id }}-${{ hashFiles('**/go.sum') }}


removed because have cached in setup actions/cache#1104 (comment)

Otherwise, we will meet error

HuSharp · 2024-04-16T05:33:37Z

.github/workflows/check.yaml

      - name: Checkout code
-        uses: actions/checkout@v3
-      - name: Restore cache
-        uses: actions/cache@v3
+        uses: actions/checkout@v4
+      - uses: actions/setup-go@v5


change the checkout and setup place because actions/setup-node#624 (comment)

HuSharp · 2024-04-16T05:37:12Z

.github/workflows/check.yaml

-        uses: actions/cache@v3
+        uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
        with:
-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-            **/.dashboard_download_cache
-          key: ${{ runner.os }}-golang-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-golang


removed because have cached in setup actions/cache#1104 (comment)

close tikv#8070 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-09-13T10:12:50Z

In response to a cherrypick label: new pull request created to branch release-7.1: #8626.

ti-chi-bot · 2024-09-13T10:12:50Z

In response to a cherrypick label: new pull request created to branch release-6.1: #8627.

close tikv#8070 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-09-13T10:12:51Z

In response to a cherrypick label: new pull request created to branch release-6.5: #8628.

close tikv#8070 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-09-13T10:17:44Z

In response to a cherrypick label: new pull request created to branch release-7.5: #8629.

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

ti-chi-bot · 2024-09-14T02:40:49Z

In response to a cherrypick label: new pull request created to branch release-8.1: #8631.

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

ti-chi-bot · 2024-09-14T06:07:13Z

@HuSharp: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-6.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

…ikv#8628) close tikv#8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

…ikv#8628) close tikv#8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Signed-off-by: lhy1024 <[email protected]>

bump action

c563883

Signed-off-by: husharp <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2024

ti-chi-bot bot requested a review from JmPotato April 16, 2024 02:58

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2024

bump action

2e5f0a1

Signed-off-by: husharp <[email protected]>

HuSharp removed the request for review from JmPotato April 16, 2024 03:04

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2024

HuSharp force-pushed the update_node16_to_20 branch 2 times, most recently from 5b1cc8c to 16a8b73 Compare April 16, 2024 03:52

fix cache

dab2894

Signed-off-by: husharp <[email protected]>

HuSharp force-pushed the update_node16_to_20 branch from 627a9b6 to dab2894 Compare April 16, 2024 05:20

HuSharp requested review from nolouch, lhy1024 and rleungx April 16, 2024 05:31

HuSharp marked this pull request as ready for review April 16, 2024 05:31

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024

HuSharp commented Apr 16, 2024

View reviewed changes

HuSharp requested a review from JmPotato April 16, 2024 05:48

Merge branch 'master' into update_node16_to_20

07dd253

nolouch approved these changes Apr 16, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2024

rleungx approved these changes Apr 16, 2024

View reviewed changes

ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Sep 13, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 13, 2024

This is an automated cherry-pick of tikv#8071

96593e2

close tikv#8070 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 13, 2024

This is an automated cherry-pick of tikv#8071

2d105da

close tikv#8070 Signed-off-by: ti-chi-bot <[email protected]>

This was referenced Sep 13, 2024

ci: transitioning action version from node 16 to node 20 (#8071) #8626

Merged

ci: transitioning action version from node 16 to node 20 (#8071) #8627

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 13, 2024

This is an automated cherry-pick of tikv#8071

4fe32af

close tikv#8070 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Sep 13, 2024

ci: transitioning action version from node 16 to node 20 (#8071) #8628

Merged

ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 13, 2024

ti-chi-bot mentioned this pull request Sep 13, 2024

ci: transitioning action version from node 16 to node 20 (#8071) #8629

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Sep 13, 2024

ci: transitioning action version from node 16 to node 20 (#8071) (#8622)

41c6bc2

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Sep 14, 2024

ti-chi-bot mentioned this pull request Sep 14, 2024

ci: transitioning action version from node 16 to node 20 (#8071) #8631

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024

ci: transitioning action version from node 16 to node 20 (#8071) (#8629)

d12786c

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024

ci: transitioning action version from node 16 to node 20 (#8071) (#8627)

335ea20

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

ti-chi-bot removed type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Sep 14, 2024

ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024

ci: transitioning action version from node 16 to node 20 (#8071) (#8631)

c14a833

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024

ci: transitioning action version from node 16 to node 20 (#8071) (#8626)

34f401d

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

HuSharp added the type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. label Sep 14, 2024

ti-chi-bot bot removed the type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. label Sep 14, 2024

ti-chi-bot bot pushed a commit that referenced this pull request Sep 20, 2024

ci: transitioning action version from node 16 to node 20 (#8071) (#8628)

e1dbf12

close #8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

lhy1024 pushed a commit to lhy1024/pd that referenced this pull request Nov 4, 2024

ci: transitioning action version from node 16 to node 20 (tikv#8071) (t…

685072d

…ikv#8628) close tikv#8070 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: transitioning action version from node 16 to node 20 #8071

ci: transitioning action version from node 16 to node 20 #8071

HuSharp commented Apr 16, 2024 •

edited

Loading

ti-chi-bot bot commented Apr 16, 2024 •

edited

Loading

ti-chi-bot bot commented Apr 16, 2024

codecov bot commented Apr 16, 2024 •

edited

Loading

HuSharp Apr 16, 2024 •

edited

Loading

HuSharp Apr 16, 2024 •

edited

Loading

HuSharp Apr 16, 2024

HuSharp Apr 16, 2024 •

edited

Loading

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 14, 2024

ti-chi-bot bot commented Sep 14, 2024

ci: transitioning action version from node 16 to node 20 #8071

ci: transitioning action version from node 16 to node 20 #8071

Conversation

HuSharp commented Apr 16, 2024 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

problems

solution

action release note and docs

Check List

Release note

ti-chi-bot bot commented Apr 16, 2024 • edited Loading

ti-chi-bot bot commented Apr 16, 2024

codecov bot commented Apr 16, 2024 • edited Loading

Codecov Report

HuSharp Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

HuSharp Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

HuSharp Apr 16, 2024

Choose a reason for hiding this comment

HuSharp Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 13, 2024

ti-chi-bot commented Sep 14, 2024

ti-chi-bot bot commented Sep 14, 2024

HuSharp commented Apr 16, 2024 •

edited

Loading

ti-chi-bot bot commented Apr 16, 2024 •

edited

Loading

codecov bot commented Apr 16, 2024 •

edited

Loading

HuSharp Apr 16, 2024 •

edited

Loading

HuSharp Apr 16, 2024 •

edited

Loading

HuSharp Apr 16, 2024 •

edited

Loading