-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: make TestKeyspaceGroupMergeIntoDefault
stable
#8080
Conversation
Signed-off-by: Ryan Leung <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8080 +/- ##
==========================================
+ Coverage 77.32% 77.39% +0.06%
==========================================
Files 469 469
Lines 61097 61097
==========================================
+ Hits 47246 47286 +40
+ Misses 10288 10259 -29
+ Partials 3563 3552 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
TestKeyspaceGroupMergeIntoDefault
stableTestKeyspaceGroupMergeIntoDefault
stable
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: de4d555
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #6991.
What is changed and how does it work?
The
allocNodesToAllKeyspaceGroups
only runs once. If we create keyspace groups by two times, it might lose the latter one.Check List
Tests
Release note