-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in keyspace config #8109
Conversation
Correct "keyspaces" to "keyspace" as referred in code: https://github.com/tikv/pd/blob/4a7bffcb3baf7a8e2515e70834d8567bc17439da/server/config/config.go#L166C1-L167C1
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @wwu. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Please sign DCO. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge cancel |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8109 +/- ##
==========================================
- Coverage 77.40% 77.31% -0.09%
==========================================
Files 471 471
Lines 61240 61240
==========================================
- Hits 47402 47348 -54
- Misses 10277 10317 +40
- Partials 3561 3575 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8d5b13b
|
ref tikv#4399 Co-authored-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: ShuNing <[email protected]>
Correct "keyspaces" to "keyspace" as referred in code: https://github.com/tikv/pd/blob/4a7bffcb3baf7a8e2515e70834d8567bc17439da/server/config/config.go#L166C1-L167C1
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note