-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix scatter counter name #8124
Conversation
Signed-off-by: husharp <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also pick to other branches
/check-issue-triage-complete |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8124 +/- ##
==========================================
- Coverage 77.39% 77.37% -0.02%
==========================================
Files 471 471
Lines 61242 61252 +10
==========================================
Hits 47396 47396
- Misses 10281 10291 +10
Partials 3565 3565
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 7da44ba
|
In response to a cherrypick label: new pull request created to branch |
close tikv#8125 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
close tikv#8125 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close #8125 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close #8125 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close #8125 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close tikv#8125 Signed-off-by: husharp <[email protected]>
close #8125 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
What problem does this PR solve?
Issue Number: Close #8125
What is changed and how does it work?
when execute
curl -X POST 'http://127.0.0.1:10080/tables/test/t/scatter'
before
after
Check List
Tests
Release note