Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: Reduce the frequency of printing logs #8160

Merged
merged 1 commit into from
May 9, 2024
Merged

controller: Reduce the frequency of printing logs #8160

merged 1 commit into from
May 9, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 9, 2024

What problem does this PR solve?

Issue Number: Close #8159

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 9, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx May 9, 2024 07:24
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2024
@nolouch nolouch added require-LGT1 Indicates that the PR requires an LGTM. and removed require-LGT1 Indicates that the PR requires an LGTM. labels May 9, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2024
@nolouch
Copy link
Contributor Author

nolouch commented May 9, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 9, 2024

This pull request has been accepted and is ready to merge.

Commit hash: b481b8d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit a674e66 into tikv:master May 9, 2024
23 checks passed
@nolouch nolouch deleted the reduce-log branch May 9, 2024 07:41
@lhy1024
Copy link
Contributor

lhy1024 commented May 20, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@lhy1024: new pull request created to branch release-8.1: #8190.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
@lhy1024
Copy link
Contributor

lhy1024 commented May 20, 2024

/cherry-pick release-7.1 release-7.5

@ti-chi-bot
Copy link
Member

@lhy1024: cannot checkout release-7.1 release-7.5: error checking out release-7.1 release-7.5: exit status 1. output: error: pathspec 'release-7.1 release-7.5' did not match any file(s) known to git

In response to this:

/cherry-pick release-7.1 release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented May 20, 2024

/cherry-pick release-7.1

@lhy1024
Copy link
Contributor

lhy1024 commented May 20, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@lhy1024: new pull request created to branch release-7.1: #8191.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 20, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8160
e1e1a5e 
close tikv#8159

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
@ti-chi-bot
Copy link
Member

@lhy1024: new pull request created to branch release-7.5: #8192.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 20, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8160
53947d2 
close tikv#8159

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
ti-chi-bot bot added a commit that referenced this pull request May 20, 2024
@ti-chi-bot @nolouch @ti-chi-bot
controller: Reduce the frequency of printing logs (#8160) (#8192)
01a8f3f 
close #8159

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request May 22, 2024
@ti-chi-bot @nolouch
controller: Reduce the frequency of printing logs (#8160) (#8191)
d5d9eab 
close #8159

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2024
@ti-chi-bot @nolouch
controller: Reduce the frequency of printing logs (#8160) (#8190)
c0818ef 
close #8159

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
@JmPotato JmPotato mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@disksing disksing disksing approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many logs when cannot reserve tokens
5 participants
@nolouch @lhy1024 @ti-chi-bot @disksing @rleungx