Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/client: unify http client in tests #8199

Merged
merged 1 commit into from
May 20, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented May 20, 2024

What problem does this PR solve?

Issue Number: Ref #7969

What is changed and how does it work?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested review from nolouch and lhy1024 May 20, 2024 06:00
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 44.11765% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 77.28%. Comparing base (6ded6f8) to head (9c73228).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8199      +/-   ##
==========================================
- Coverage   77.32%   77.28%   -0.05%     
==========================================
  Files         471      471              
  Lines       61353    61372      +19     
==========================================
- Hits        47442    47432      -10     
- Misses      10349    10378      +29     
  Partials     3562     3562              
Flag Coverage Δ
unittests 77.28% <44.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp mentioned this pull request May 20, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 20, 2024
@nolouch
Copy link
Contributor

nolouch commented May 20, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9c73228

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3e672b2 into tikv:master May 20, 2024
18 of 20 checks passed
@HuSharp HuSharp deleted the unify_httpclient branch May 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants