Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/tso: add IDAllocator to make keyspace test stable #8202

Merged
merged 5 commits into from
May 21, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented May 21, 2024

What problem does this PR solve?

Issue Number: Close #8099

What is changed and how does it work?

add IDAllocator to make test stable

Check List

Tests

  • Integration test

Release note

None.

HuSharp added 2 commits May 21, 2024 11:57
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested review from JmPotato and rleungx May 21, 2024 04:00
Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (7731ee4) to head (65ca783).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8202      +/-   ##
==========================================
- Coverage   77.34%   77.23%   -0.12%     
==========================================
  Files         471      471              
  Lines       61398    61407       +9     
==========================================
- Hits        47489    47426      -63     
- Misses      10350    10412      +62     
- Partials     3559     3569      +10     
Flag Coverage Δ
unittests 77.23% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp requested a review from nolouch May 21, 2024 05:53
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 21, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 21, 2024
@HuSharp
Copy link
Member Author

HuSharp commented May 21, 2024

/hold
test still failed

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Member Author

HuSharp commented May 21, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@HuSharp
Copy link
Member Author

HuSharp commented May 21, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

This pull request has been accepted and is ready to merge.

Commit hash: d163cbe

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 21, 2024
Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 0e73b7a into tikv:master May 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test TestTSOKeyspaceGroupSplitElection
3 participants