Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: make store,region,replica configurable in cases #8215

Merged
merged 3 commits into from
May 30, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 24, 2024

What problem does this PR solve?

Issue Number: Ref #8135

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024 lhy1024 requested a review from HuSharp May 24, 2024 08:33
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.41%. Comparing base (c498063) to head (9623d63).

Current head 9623d63 differs from pull request most recent head 32e7f8a

Please upload reports for the commit 32e7f8a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8215      +/-   ##
==========================================
+ Coverage   77.25%   77.41%   +0.16%     
==========================================
  Files         471      470       -1     
  Lines       61339    61454     +115     
==========================================
+ Hits        47385    47577     +192     
+ Misses      10382    10315      -67     
+ Partials     3572     3562      -10     
Flag Coverage Δ
unittests 77.41% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2024
@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label May 30, 2024
@HuSharp
Copy link
Member

HuSharp commented May 30, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9623d63

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2024
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 52389b0 into tikv:master May 30, 2024
15 checks passed
@lhy1024 lhy1024 deleted the sim-config branch May 30, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants