Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/simulator: add store api and replace simulator http with SDK #8245

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jun 4, 2024

What problem does this PR solve?

Issue Number: Ref #8135

What is changed and how does it work?

add store api and replace simulator http with SDK

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@HuSharp HuSharp requested review from JmPotato, lhy1024 and rleungx June 4, 2024 07:23
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 4, 2024

/check-dco

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jun 4, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (d44d721) to head (c73cd5b).
Report is 1 commits behind head on master.

Current head c73cd5b differs from pull request most recent head bb6ecd2

Please upload reports for the commit bb6ecd2 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8245      +/-   ##
==========================================
- Coverage   77.46%   77.34%   -0.13%     
==========================================
  Files         471      471              
  Lines       61365    61370       +5     
==========================================
- Hits        47539    47469      -70     
- Misses      10275    10350      +75     
  Partials     3551     3551              
Flag Coverage Δ
unittests 77.34% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 5, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jun 5, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c73cd5b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 301fabb into tikv:master Jun 5, 2024
15 checks passed
@HuSharp HuSharp deleted the replace_simulator branch June 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants