Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/simulator: resolve simulator race #8376

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jul 8, 2024

What problem does this PR solve?

Issue Number: Ref #8135

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

@HuSharp HuSharp requested a review from lhy1024 July 8, 2024 07:37
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2024
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the fix_simulator_race branch from f880f44 to dff1346 Compare July 8, 2024 07:40
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.15%. Comparing base (bdbe73e) to head (170ddde).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8376      +/-   ##
==========================================
- Coverage   77.32%   77.15%   -0.17%     
==========================================
  Files         470      470              
  Lines       61687    61689       +2     
==========================================
- Hits        47701    47599     -102     
- Misses      10405    10501      +96     
- Partials     3581     3589       +8     
Flag Coverage Δ
unittests 77.15% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 9, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 01:48:36.921192086 +0000 UTC m=+322214.156426200: ☑️ agreed by lhy1024.
  • 2024-07-09 03:32:55.723628964 +0000 UTC m=+328472.958863077: ☑️ agreed by rleungx.

Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 90273dd into tikv:master Jul 9, 2024
23 of 25 checks passed
@HuSharp HuSharp deleted the fix_simulator_race branch July 9, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants