-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tso: replace priorityCheck ResetLeader
with TransferPrimary
#8597
Conversation
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
ResetLeader
with TransferPrimary
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8597 +/- ##
==========================================
- Coverage 77.60% 77.56% -0.04%
==========================================
Files 474 474
Lines 61864 61879 +15
==========================================
- Hits 48007 47994 -13
- Misses 10317 10343 +26
- Partials 3540 3542 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: husharp <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
The issue detail process is #8533 (comment)
tso's priority uses
ResetLeader
instead ofmoveLeader
.The process is:
Secondary can be elected as new primary because of time gap which is not stable!!!
Issue Number: Close #8533
What is changed and how does it work?
transfer primary
is actually asmove etcd leader
.ResetLeader
withtransfer primary
, which is more time efficient and can avoid time lag.Check List
Tests
Release note