Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: udpate OWNERS_ALIASES file #8598

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Sep 6, 2024

  • transfer easonn7 to BenMeadowcroft
  • transfer kevin-xianliu to yudongusa

What problem does this PR solve?

Issue Number: ref #8167

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

- transfer `easonn7` to `BenMeadowcroft`
- transfer `kevin-xianliu` to `yudongusa`

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/cc @yudongusa @benmeadowcroft @niubell

Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa, benmeadowcroft, niubell.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa @benmeadowcroft @niubell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (0bb9b13) to head (e88556f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8598      +/-   ##
==========================================
+ Coverage   77.58%   77.63%   +0.05%     
==========================================
  Files         474      474              
  Lines       61852    61852              
==========================================
+ Hits        47985    48020      +35     
+ Misses      10323    10296      -27     
+ Partials     3544     3536       -8     
Flag Coverage Δ
unittests 77.63% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2024
@HuSharp
Copy link
Member

HuSharp commented Sep 6, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 6, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/cc @rleungx

@ti-chi-bot ti-chi-bot bot requested a review from rleungx September 6, 2024 09:39
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-06 09:21:12.273832998 +0000 UTC m=+2542.014256937: ☑️ agreed by HuSharp.
  • 2024-09-06 09:45:39.612224174 +0000 UTC m=+4009.352648113: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 39b89e1 into tikv:master Sep 6, 2024
26 checks passed
@wuhuizuo wuhuizuo deleted the ci/update-owners branch September 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants