Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler_test: change scheduler check order #8613

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Sep 10, 2024

What problem does this PR solve?

Issue Number: Close #8612

What is changed and how does it work?

It's better to wait scheduler callback finished.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Sep 10, 2024
@HuSharp HuSharp requested a review from rleungx September 10, 2024 07:44
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-10 07:51:33.479803895 +0000 UTC m=+342763.220227834: ☑️ agreed by rleungx.
  • 2024-09-10 07:55:25.137107713 +0000 UTC m=+342994.877531662: ☑️ agreed by lhy1024.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (b95ddda) to head (ca7e9fc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8613      +/-   ##
==========================================
+ Coverage   77.61%   77.63%   +0.02%     
==========================================
  Files         474      474              
  Lines       61891    61891              
==========================================
+ Hits        48035    48050      +15     
+ Misses      10310    10303       -7     
+ Partials     3546     3538       -8     
Flag Coverage Δ
unittests 77.63% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 3bd5e3c into tikv:master Sep 10, 2024
25 checks passed
@HuSharp HuSharp deleted the fix_scheduler_test branch September 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestScheduler is flaky
3 participants