Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go to 1.23 #8637

Merged
merged 4 commits into from
Oct 8, 2024
Merged

*: upgrade go to 1.23 #8637

merged 4 commits into from
Oct 8, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 20, 2024

What problem does this PR solve?

Issue Number: Close #8644

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2024
@purelind
Copy link
Contributor

/hold

Waiting for the test report to be completed.

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Sep 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Oct 8, 2024

/test build

@rleungx
Copy link
Member Author

rleungx commented Oct 8, 2024

/test pull-integration-realcluster-test

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (26ced22) to head (06e0739).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8637      +/-   ##
==========================================
- Coverage   77.54%   71.68%   -5.87%     
==========================================
  Files         474      517      +43     
  Lines       62359    67450    +5091     
==========================================
- Hits        48358    48353       -5     
- Misses      10441    15525    +5084     
- Partials     3560     3572      +12     
Flag Coverage Δ
unittests 71.68% <70.58%> (-5.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 8, 2024
@purelind
Copy link
Contributor

purelind commented Oct 8, 2024

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

@purelind: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2024
@rleungx
Copy link
Member Author

rleungx commented Oct 8, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 03:20:36.831625471 +0000 UTC m=+929792.251838467: ☑️ agreed by lhy1024.
  • 2024-10-08 03:25:40.254453941 +0000 UTC m=+930095.674666953: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 697d907 into tikv:master Oct 8, 2024
21 of 25 checks passed
@rleungx rleungx deleted the upgrade-go-1.23 branch October 8, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go version to 1.23
5 participants