statistics: add gc in hot peer cache #8702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8702 +/- ##
==========================================
+ Coverage 75.56% 75.59% +0.03%
==========================================
Files 460 460
Lines 72107 72135 +28
==========================================
+ Hits 54489 54534 +45
+ Misses 14126 14108 -18
- Partials 3492 3493 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
rleungx
reviewed
Oct 21, 2024
pkg/statistics/hot_peer_cache.go
Outdated
| @@ -115,6 +116,7 @@ func (f *HotPeerCache) UpdateStat(item *HotPeerStat) { | |||
| return | |||
| } | |||
| f.incMetrics(item.actionType, item.StoreID) | |||
| f.removeExpiredItems() | |||
There was a problem hiding this comment.
Will it be called every time we receive a region heartbeat?
There was a problem hiding this comment.
In previous, removeItem or putItem will call tn.maintain() every time. In this PR, it will call only after topNTTL
rleungx
reviewed
Oct 22, 2024
pkg/statistics/hot_cache.go
Outdated
| @@ -80,7 +80,7 @@ func (w *HotCache) CheckReadAsync(task func(cache *HotPeerCache)) bool { | |||
| func (w *HotCache) RegionStats(kind utils.RWType, minHotDegree int) map[uint64][]*HotPeerStat { | |||
| ret := make(chan map[uint64][]*HotPeerStat, 1) | |||
| collectRegionStatsTask := func(cache *HotPeerCache) { | |||
| ret <- cache.RegionStats(minHotDegree) | |||
| ret <- cache.PeerStats(minHotDegree) | |||
There was a problem hiding this comment.
Why change the name, it's not consistent with other places.
There was a problem hiding this comment.
Okay, I'll keep the TODO and change them in another PR uniform.
|
/check-issue-triage-complete |
rleungx
approved these changes
Oct 22, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
okJiang
reviewed
Oct 25, 2024
pkg/statistics/utils/topn_test.go
Outdated
| @@ -217,6 +217,7 @@ func TestTTL(t *testing.T) { | |||
| } | |||
| re.True(tn.Put(item)) | |||
| } | |||
| tn.RemoveExpired() | |||
pkg/statistics/hot_peer_cache.go
Outdated
| @@ -548,6 +551,36 @@ func (f *HotPeerCache) removeItem(item *HotPeerStat) { | |||
| } | |||
| } | |||
|
|
|||
| func (f *HotPeerCache) removeExpiredItems() { | |||
Signed-off-by: lhy1024 <[email protected]>
okJiang
approved these changes
Oct 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
needs-cherry-pick-release-7.1
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Oct 30, 2024
close tikv#8698 Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
lhy1024
added a commit
to ti-chi-bot/pd
that referenced
this pull request
Oct 30, 2024
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
close #8698 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
the
needs-cherry-pick-release-7.5
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Dec 5, 2024
close tikv#8698 Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot bot
added a commit
that referenced
this pull request
Dec 9, 2024
close #8698 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
the
needs-cherry-pick-release-8.1
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Dec 11, 2024
close tikv#8698 Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot bot
added a commit
that referenced
this pull request
Dec 12, 2024
close #8698 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8698
What is changed and how does it work?
Check List
Tests
Release note