-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ms/tso: move startGlobalAllocatorLoop
outside NewAllocatorManager
#8725
Conversation
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8725 +/- ##
==========================================
+ Coverage 69.98% 70.02% +0.03%
==========================================
Files 517 517
Lines 79947 79953 +6
==========================================
+ Hits 55953 55987 +34
+ Misses 20433 20404 -29
- Partials 3561 3562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@okJiang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Ref #4399
ms/tso: move
startGlobalAllocatorLoop
outsideNewAllocatorManager
We call
startGlobalAllocatorLoop
where we need it. We only need it when setting API mode and TSO server start.What is changed and how does it work?
Check List
Tests
Release note