Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: reduce rand NewSource (#8675) #8728

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8675

What problem does this PR solve?

Issue Number: Close #8674.

What is changed and how does it work?

Initialize rand when creating schedulers and checkers instead of initializing it every time scheduling.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 18, 2024
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-8675-to-release-7.5 branch from c408dd2 to 5037123 Compare October 18, 2024 08:55
@rleungx rleungx requested review from JmPotato and lhy1024 October 21, 2024 03:26
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 21, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-21 03:29:48.321584336 +0000 UTC m=+235389.018374939: ☑️ agreed by lhy1024.
  • 2024-10-28 05:36:23.603340668 +0000 UTC m=+241696.442496211: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 11389bb into tikv:release-7.5 Oct 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants