Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker, statistic: avoid leak in label statistic (#8703) #8735

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8703

What problem does this PR solve?

Issue Number: Close #8700

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 22, 2024
@lhy1024 lhy1024 requested review from rleungx and JmPotato October 22, 2024 03:52
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 04:05:16.212666143 +0000 UTC m=+323916.909456764: ☑️ agreed by JmPotato.
  • 2024-10-22 06:28:39.018849185 +0000 UTC m=+332519.715639807: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.4@2d8f681). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-8.4    #8735   +/-   ##
==============================================
  Coverage               ?   70.02%           
==============================================
  Files                  ?      517           
  Lines                  ?    79958           
  Branches               ?        0           
==============================================
  Hits                   ?    55988           
  Misses                 ?    20410           
  Partials               ?     3560           
Flag Coverage Δ
unittests 70.02% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit fc6e45c into tikv:release-8.4 Oct 22, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants