Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enable more linters #8742

Merged
merged 4 commits into from
Oct 25, 2024
Merged

*: enable more linters #8742

merged 4 commits into from
Oct 25, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 23, 2024

What problem does this PR solve?

Issue Number: ref #4322

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 23, 2024
@rleungx rleungx requested a review from lhy1024 October 23, 2024 07:01
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the enable-more-linter branch from 25d7078 to c57a738 Compare October 23, 2024 07:52
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (988c9a3) to head (b182bb1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8742      +/-   ##
==========================================
+ Coverage   75.56%   75.68%   +0.12%     
==========================================
  Files         460      460              
  Lines       72107    72107              
==========================================
+ Hits        54489    54576      +87     
+ Misses      14126    14044      -82     
+ Partials     3492     3487       -5     
Flag Coverage Δ
unittests 75.68% <95.77%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

.golangci.yml Outdated
- makezero
- protogetter
- reassign
- zerologlint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we don't use zerolog, if we don't use it, I think we don't have to add this linter. Less linters have less check time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 25, 2024
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so big

Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-25 02:15:13.165307291 +0000 UTC m=+576513.862097898: ☑️ agreed by okJiang.
  • 2024-10-25 03:44:14.128229999 +0000 UTC m=+581854.825020626: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 1474864 into tikv:master Oct 25, 2024
25 checks passed
@rleungx rleungx deleted the enable-more-linter branch October 25, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants