-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable more linters #8742
*: enable more linters #8742
Conversation
Signed-off-by: Ryan Leung <[email protected]>
25d7078
to
c57a738
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8742 +/- ##
==========================================
+ Coverage 75.56% 75.68% +0.12%
==========================================
Files 460 460
Lines 72107 72107
==========================================
+ Hits 54489 54576 +87
+ Misses 14126 14044 -82
+ Partials 3492 3487 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
.golangci.yml
Outdated
- makezero | ||
- protogetter | ||
- reassign | ||
- zerologlint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we don't use zerolog
, if we don't use it, I think we don't have to add this linter. Less linters have less check time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
Signed-off-by: Ryan Leung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so big
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #4322
What is changed and how does it work?
Check List
Tests
Release note