Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: return error when create grant/evict leader scheduler #8760

Merged
merged 2 commits into from
Nov 4, 2024
Merged

api: return error when create grant/evict leader scheduler #8760

merged 2 commits into from
Nov 4, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Oct 31, 2024

What problem does this PR solve?

Issue Number: Ref #8759

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix an issue that pd can't report error normally when creating grant/evict leader scheduler.

@HuSharp @ti-chi-bot @okJiang
api: update evict-leader-scheduler&grant-leader-scheduler to return t…
f574857 
…he same success message (tikv#7802)

ref tikv#7672

Signed-off-by: husharp <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
lhy1024
lhy1024 reviewed Oct 31, 2024
View reviewed changes
server/api/scheduler.go
// we should ensure whether it is the first time to create evict-leader-scheduler
// or just update the evict-leader.
if exist {
h.r.JSON(w, http.StatusOK, "The scheduler has been applied to the store.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need add a test for it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add a test to master, and cp it to this pr

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-01 07:19:06.656925727 +0000 UTC m=+593459.496081265: ☑️ agreed by rleungx.
  • 2024-11-01 09:26:04.123910973 +0000 UTC m=+601076.963066518: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 935b200 into tikv:release-7.5 Nov 4, 2024
21 checks passed
@okJiang okJiang deleted the 7.5-report-error branch November 4, 2024 07:22
@okJiang
Copy link
Member Author

okJiang commented Nov 4, 2024

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@okJiang: new pull request created to branch release-7.1: #8769.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@ti-chi-bot @HuSharp
api: return error when create grant/evict leader scheduler (#8760) (#…
ba7d856 
…8769)

ref #8759

Signed-off-by: husharp <[email protected]>
Signed-off-by: okJiang <[email protected]>

Co-authored-by: Hu# <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Nov 6, 2024

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@okJiang: new pull request created to branch release-6.5: #8777.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2024
@ti-chi-bot @HuSharp
api: return error when create grant/evict leader scheduler (#8760) (#…
959b578 
…8777)

ref #8759

Signed-off-by: husharp <[email protected]>
Signed-off-by: okJiang <[email protected]>

Co-authored-by: Hu# <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@okJiang @ti-chi-bot @lhy1024 @rleungx @HuSharp