Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/tso: add a TSO wait failed duration observer #8763

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Nov 4, 2024

What problem does this PR solve?

Issue Number: ref #8281.

What is changed and how does it work?

Add a TSO wait failed duration observer.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/metrics Metrics. component/tso Timestamp Oracle. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@JmPotato JmPotato requested review from lhy1024 and rleungx November 4, 2024 03:40
@JmPotato JmPotato force-pushed the refine_tso_wait_metrics branch from dc994c7 to 4e8b4f5 Compare November 4, 2024 03:43
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (60b960a) to head (4e8b4f5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8763      +/-   ##
==========================================
+ Coverage   75.52%   75.54%   +0.01%     
==========================================
  Files         461      461              
  Lines       72273    72275       +2     
==========================================
+ Hits        54587    54601      +14     
+ Misses      14182    14177       -5     
+ Partials     3504     3497       -7     
Flag Coverage Δ
unittests 75.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 03:55:55.710873482 +0000 UTC m=+840468.550029030: ☑️ agreed by rleungx.
  • 2024-11-04 05:28:40.754938392 +0000 UTC m=+846033.594093935: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 5d32653 into tikv:master Nov 4, 2024
25 checks passed
@JmPotato JmPotato deleted the refine_tso_wait_metrics branch November 4, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/metrics Metrics. component/tso Timestamp Oracle. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants