keypath: unify leader/primary path #8859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8859 +/- ##
==========================================
+ Coverage 76.14% 76.23% +0.08%
==========================================
Files 458 458
Lines 70208 70213 +5
==========================================
+ Hits 53462 53528 +66
+ Misses 13389 13336 -53
+ Partials 3357 3349 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhy1024
approved these changes
Nov 29, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
size/XL
|
/retest |
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
size/L
|
/retest |
rleungx
reviewed
Dec 2, 2024
| @@ -57,6 +67,17 @@ func LeaderPath(p *MsParam) string { | |||
| return fmt.Sprintf(msLeaderPathFormat, ClusterID(), p.ServiceName) | |||
| } | |||
|
|
|||
| // ExpectedPrimaryPath returns the expected_primary path. | |||
| func ExpectedPrimaryPath(p *MsParam) string { | |||
| if p.ServiceName == "tso" { | |||
Signed-off-by: okJiang <[email protected]>
rleungx
approved these changes
Dec 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #8582
What is changed and how does it work?
Check List
Tests
Release note