Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: return not found when region doesn't exist #8869

Merged
merged 4 commits into from
Dec 25, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 4, 2024

What problem does this PR solve?

Issue Number: Close #8868

What is changed and how does it work?

Check List

Tests

  • Unit test
    Before:
    image
    After:
    image

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.31%. Comparing base (95bfbe6) to head (ebf6176).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8869      +/-   ##
==========================================
+ Coverage   76.25%   76.31%   +0.05%     
==========================================
  Files         463      463              
  Lines       70458    70474      +16     
==========================================
+ Hits        53731    53785      +54     
+ Misses      13369    13342      -27     
+ Partials     3358     3347      -11     
Flag Coverage Δ
unittests 76.31% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 6, 2024

tidb, tikv, tiup do not call region/key or region/id

Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern here is that some of the downstream components may rely on this behavior to retry (when the result is empty), will this break the compatibility?

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 25, 2024

My concern here is that some of the downstream components may rely on this behavior to retry (when the result is empty), will this break the compatibility?

this api is not used by tidb, tikv, tiup, it is used by pd-ctl

Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-25 08:12:57.866145934 +0000 UTC m=+1635767.954948475: ☑️ agreed by rleungx.
  • 2024-12-25 08:36:21.339129132 +0000 UTC m=+1637171.427931675: ☑️ agreed by JmPotato.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 25, 2024

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit c2f72ac into tikv:master Dec 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd-ctl return error result when region doesn't exist
3 participants