-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: return not found when region doesn't exist #8869
Conversation
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8869 +/- ##
==========================================
+ Coverage 76.25% 76.31% +0.05%
==========================================
Files 463 463
Lines 70458 70474 +16
==========================================
+ Hits 53731 53785 +54
+ Misses 13369 13342 -27
+ Partials 3358 3347 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
tidb, tikv, tiup do not call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern here is that some of the downstream components may rely on this behavior to retry (when the result is empty), will this break the compatibility?
this api is not used by tidb, tikv, tiup, it is used by pd-ctl |
Signed-off-by: lhy1024 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-integration-realcluster-test |
What problem does this PR solve?
Issue Number: Close #8868
What is changed and how does it work?
Check List
Tests
Before:
After:
Release note