Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: introduce an independent region client interface #8874

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Dec 5, 2024

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Introduce an independent region client interface.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Dec 5, 2024
@JmPotato JmPotato requested review from okJiang and rleungx December 5, 2024 15:13
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.25%. Comparing base (29dfaf9) to head (15396ee).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8874      +/-   ##
==========================================
+ Coverage   76.14%   76.25%   +0.10%     
==========================================
  Files         458      460       +2     
  Lines       70208    70239      +31     
==========================================
+ Hits        53462    53559      +97     
+ Misses      13389    13333      -56     
+ Partials     3357     3347      -10     
Flag Coverage Δ
unittests 76.25% <76.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

client/client.go Outdated Show resolved Hide resolved
@JmPotato JmPotato force-pushed the independent_region_client branch from 4d58b18 to 2b53680 Compare December 9, 2024 07:03
@JmPotato JmPotato requested a review from rleungx December 9, 2024 07:03
@JmPotato JmPotato force-pushed the independent_region_client branch from 2b53680 to 15396ee Compare December 9, 2024 08:04
@JmPotato JmPotato requested a review from rleungx December 9, 2024 08:04
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 08:08:44.401182835 +0000 UTC m=+253114.489985376: ☑️ agreed by rleungx.
  • 2024-12-09 08:37:06.692829453 +0000 UTC m=+254816.781631996: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 536ae49 into tikv:master Dec 9, 2024
25 checks passed
@JmPotato JmPotato deleted the independent_region_client branch December 9, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants