Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade github.com/aws/aws-sdk-go-v2/config from v1.18 to v1.25 #8883

Merged
merged 3 commits into from
Dec 9, 2024
Merged

*: upgrade github.com/aws/aws-sdk-go-v2/config from v1.18 to v1.25 #8883

merged 3 commits into from
Dec 9, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Dec 9, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@okJiang
Copy link
Member Author

okJiang commented Dec 9, 2024

/retest

@okJiang okJiang marked this pull request as ready for review December 9, 2024 08:43
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (536ae49) to head (214f323).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8883      +/-   ##
==========================================
- Coverage   76.16%   76.12%   -0.04%     
==========================================
  Files         460      460              
  Lines       70239    70239              
==========================================
- Hits        53500    53472      -28     
- Misses      13386    13405      +19     
- Partials     3353     3362       +9
Flag Coverage Δ
unittests 76.12% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Dec 9, 2024
View reviewed changes
go.mod Outdated
@@ -65,6 +65,8 @@ require (
gotest.tools/gotestsum v1.7.0
)

require github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.10.3 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need format

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 09:12:22.497442044 +0000 UTC m=+256932.586244586: ☑️ agreed by rleungx.
  • 2024-12-09 09:17:18.551872829 +0000 UTC m=+257228.640675369: ☑️ agreed by bufferflies.

@ti-chi-bot ti-chi-bot bot merged commit 7df0ff9 into tikv:master Dec 9, 2024
25 checks passed
@csuzhangxc
Copy link

@okJiang Do we need to upgrade github.com/aws/aws-sdk-go-v2/service/kms? ref aws/aws-sdk-go-v2#2370

@okJiang okJiang mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@bufferflies bufferflies bufferflies approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okJiang @csuzhangxc @bufferflies @rleungx