resource control: fix unsafe usage of timer.Reset (#8877) #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close tikv#8876 Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
dco-signoff: yes
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XL
Signed-off-by: lhy1024 <[email protected]>
|
maybe we need to pick all relative code about timer.reset to 7.1? |
Signed-off-by: lhy1024 <[email protected]>
close tikv#6719 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
size/XXL
rleungx
approved these changes
Dec 18, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
rleungx
reviewed
Dec 18, 2024
Signed-off-by: lhy1024 <[email protected]>
lhy1024
force-pushed
the
cherry-pick-8877-to-release-7.1
branch
from
4b36b40 to
120fe68
Compare
rleungx
reviewed
Dec 18, 2024
| select { | ||
| case <-ctx.Done(): | ||
| log.Info("stop synchronizing with leader due to context canceled") | ||
| return | ||
| case <-time.After(retryInterval): | ||
| case <-timer.C: | ||
| timer.Stop() |
There was a problem hiding this comment.
If returned the timer won't be stopped.
Signed-off-by: lhy1024 <[email protected]>
bufferflies
approved these changes
Dec 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8877
What problem does this PR solve?
Issue Number: Close #8876
What is changed and how does it work?
Check List
Tests
Release note