*: unify the gRPC errors #8910
Merged
*: unify the gRPC errors #8910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
ti-chi-bot
bot
added
the
size/XL
rleungx
commented
Dec 12, 2024
| @@ -589,19 +570,18 @@ func (s *GrpcServer) Tso(stream pdpb.PD_TsoServer) error { | |||
| start := time.Now() | |||
| // TSO uses leader lease to determine validity. No need to check leader here. | |||
| if s.IsClosed() { | |||
| return status.Errorf(codes.Unknown, "server not started") | |||
There was a problem hiding this comment.
Here I change the status code to Unavailable, the same as other places.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8910 +/- ##
==========================================
- Coverage 76.28% 76.24% -0.04%
==========================================
Files 462 463 +1
Lines 70447 70452 +5
==========================================
- Hits 53741 53718 -23
- Misses 13362 13382 +20
- Partials 3344 3352 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
okJiang
approved these changes
Dec 13, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
JmPotato
approved these changes
Dec 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #8922
What is changed and how does it work?
Check List
Tests
Release note