-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana: Add gRPC Received commands rate
panel
#8921
base: master
Are you sure you want to change the base?
Changes from 2 commits
c966a57
a547429
b0995d1
e9c2b1b
9888398
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8937,6 +8937,226 @@ | |
"align": false, | ||
"alignLevel": null | ||
} | ||
}, | ||
{ | ||
"aliasColors": {}, | ||
"dashLength": 10, | ||
"datasource": "${DS_TEST-CLUSTER}", | ||
"description": "The rate of received each kind of gRPC commands", | ||
"editable": true, | ||
"fill": 1, | ||
"grid": {}, | ||
"gridPos": { | ||
"h": 8, | ||
"w": 12, | ||
"x": 12, | ||
"y": 127 | ||
}, | ||
"id": 904, | ||
"legend": { | ||
"alignAsTable": true, | ||
"avg": false, | ||
"current": true, | ||
"hideEmpty": true, | ||
"hideZero": true, | ||
"max": true, | ||
"min": false, | ||
"rightSide": true, | ||
"show": true, | ||
"sideWidth": 300, | ||
"total": false, | ||
"values": true | ||
}, | ||
"lines": true, | ||
"linewidth": 1, | ||
"links": [], | ||
"nullPointMode": "null as zero", | ||
"paceLength": 10, | ||
"pointradius": 5, | ||
"renderer": "flot", | ||
"seriesOverrides": [], | ||
"spaceLength": 10, | ||
"targets": [ | ||
{ | ||
"expr": "sum(rate(grpc_server_started_total{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\"}[1m])) by (instance, grpc_method)", | ||
"legendFormat": "{{instance}}-{{grpc_method}}", | ||
"interval": "", | ||
"exemplar": true, | ||
"intervalFactor": 2, | ||
"refId": "A", | ||
"step": 4 | ||
} | ||
], | ||
"thresholds": [], | ||
"timeRegions": [], | ||
"title": "gRPC Received commands rate", | ||
"tooltip": { | ||
"msResolution": false, | ||
"shared": true, | ||
"sort": 0, | ||
"value_type": "cumulative" | ||
}, | ||
"type": "graph", | ||
"xaxis": { | ||
"buckets": null, | ||
"mode": "time", | ||
"name": null, | ||
"show": true, | ||
"values": [] | ||
}, | ||
"yaxes": [ | ||
{ | ||
"format": "ops", | ||
"label": null, | ||
"logBase": 10, | ||
"max": null, | ||
"min": null, | ||
"show": true | ||
}, | ||
{ | ||
"format": "short", | ||
"label": null, | ||
"logBase": 1, | ||
"max": null, | ||
"min": null, | ||
"show": true | ||
} | ||
], | ||
"yaxis": { | ||
"align": false, | ||
"alignLevel": null | ||
}, | ||
"options": { | ||
"alertThreshold": true | ||
}, | ||
"fieldConfig": { | ||
"defaults": {}, | ||
"overrides": [] | ||
}, | ||
"pluginVersion": "7.5.17", | ||
"bars": false, | ||
"dashes": false, | ||
"decimals": null, | ||
"error": false, | ||
"percentage": false, | ||
"points": false, | ||
"stack": false, | ||
"steppedLine": false, | ||
"timeFrom": null, | ||
"timeShift": null, | ||
"fillGradient": 0, | ||
"hiddenSeries": false | ||
}, | ||
{ | ||
"aliasColors": {}, | ||
"dashLength": 10, | ||
"datasource": "${DS_TEST-CLUSTER}", | ||
"description": "The error rate of handled gRPC commands", | ||
"editable": true, | ||
"fieldConfig": { | ||
"defaults": {}, | ||
"overrides": [] | ||
}, | ||
"fill": 1, | ||
"grid": {}, | ||
"gridPos": { | ||
"h": 8, | ||
"w": 12, | ||
"x": 0, | ||
"y": 135 | ||
}, | ||
"id": 905, | ||
"legend": { | ||
"alignAsTable": true, | ||
"avg": false, | ||
"current": true, | ||
"hideEmpty": true, | ||
"hideZero": true, | ||
"max": true, | ||
"min": false, | ||
"rightSide": true, | ||
"show": true, | ||
"sideWidth": 300, | ||
"total": false, | ||
"values": true | ||
}, | ||
"lines": true, | ||
"linewidth": 1, | ||
"links": [], | ||
"nullPointMode": "null as zero", | ||
"options": { | ||
"alertThreshold": true | ||
}, | ||
"paceLength": 10, | ||
"pluginVersion": "7.5.17", | ||
"pointradius": 5, | ||
"renderer": "flot", | ||
"seriesOverrides": [], | ||
"spaceLength": 10, | ||
"targets": [ | ||
{ | ||
"expr": "sum(rate(grpc_server_handled_total{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", grpc_type=\"unary\", grpc_code!=\"OK\"}[1m])) by (grpc_method)", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about adding one expr as unary total about ignoring grpc_code? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"legendFormat": "{{grpc_method}}", | ||
"interval": "", | ||
"exemplar": true, | ||
"intervalFactor": 2, | ||
"refId": "A", | ||
"step": 4 | ||
} | ||
], | ||
"thresholds": [], | ||
"timeRegions": [], | ||
"title": "gRPC Error rate", | ||
"tooltip": { | ||
"msResolution": false, | ||
"shared": true, | ||
"sort": 0, | ||
"value_type": "cumulative" | ||
}, | ||
"type": "graph", | ||
"xaxis": { | ||
"buckets": null, | ||
"mode": "time", | ||
"name": null, | ||
"show": true, | ||
"values": [] | ||
}, | ||
"yaxes": [ | ||
{ | ||
"format": "ops", | ||
"label": null, | ||
"logBase": 10, | ||
"max": null, | ||
"min": null, | ||
"show": true, | ||
"$$hashKey": "object:132" | ||
}, | ||
{ | ||
"format": "short", | ||
"label": null, | ||
"logBase": 1, | ||
"max": null, | ||
"min": null, | ||
"show": true, | ||
"$$hashKey": "object:133" | ||
} | ||
], | ||
"yaxis": { | ||
"align": false, | ||
"alignLevel": null | ||
}, | ||
"bars": false, | ||
"dashes": false, | ||
"decimals": null, | ||
"error": false, | ||
"fillGradient": 0, | ||
"hiddenSeries": false, | ||
"percentage": false, | ||
"points": false, | ||
"stack": false, | ||
"steppedLine": false, | ||
"timeFrom": null, | ||
"timeShift": null | ||
} | ||
], | ||
"repeat": null, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about also adding the error rate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it. But btw, it can't catch the error hide in the header, like this
pd/server/grpc_service.go
Line 2071 in 2d970a6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment or raise an issue for further improvement.